New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main/curl: fix missing static library symbols #6264
Conversation
I am getting errors like "undefined reference to `nghttp2_http2_strerror'" for anything related to nghttp2 when trying to statically link to libcurl.a. Does this resolve that too? I see there is no static lib built for nghttp2 in current package, only the shared lib. |
I'm also facing this issue. This is a first step, this doesn't solve the missing |
Do we want a new |
d531ead
to
a3b5142
Compare
Do we want to remove the static function now that |
This is in main/ and I don't know if this apkbuild could get backported. |
@@ -82,7 +82,7 @@ builddir="$srcdir/$pkgname-$pkgver" | |||
build() { | |||
cd "$builddir" | |||
autoreconf -vif | |||
./configure \ | |||
./configure LDFLAGS=-static PKG_CONFIG='pkg-config --static' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this will enforce static linking of curl itself. I don't mind that we ship a static library of curl in a subpackage, but we will not build curl static for all of our users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No? I got:
ldd usr/bin/curl
/lib/ld-musl-x86_64.so.1 (0x7f9c22c9d000)
libssl.so.1.1 => /lib/libssl.so.1.1 (0x7f9c22b70000)
libcrypto.so.1.1 => /lib/libcrypto.so.1.1 (0x7f9c228f2000)
libz.so.1 => /lib/libz.so.1 (0x7f9c226db000)
libc.musl-x86_64.so.1 => /lib/ld-musl-x86_64.so.1 (0x7f9c22c9d000)
After testing it again, the static linking already works by changing |
I got this information curl/curl#2516 (comment).
That's why @brentp and me have this undefined reference when trying to static link - static libcurl depends on shared nghttp2. |
Linking to
libcurl.a
results of missing symbols.There is the same problem with
libssh2.a
.