Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing/i3status: add maintainer to i3status and set !check #7552

Closed

Conversation

yjftsjthsd-g
Copy link

Add myself as maintainer on i3status, and explicitly specify that it has
no test suite (when testing to make sure I could build locally, it
complained, so I confirmed that upstream doesn't ship any tests in the
current stable version).

Add myself as maintainer on i3status, and explicitly specify that it has
no test suite (when testing to make sure I could build locally, it
complained, so I confirmed that upstream doesn't ship any tests in the
current stable version).
@probot-autolabeler probot-autolabeler bot added the R-testing Testing repository label May 4, 2019
Copy link
Contributor

@ncopa ncopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a bit hideous (sorry), but the maintainer will be included in the final .apk so we need bump pkgrel.

@yjftsjthsd-g
Copy link
Author

That's reasonable, given exactly what pkgrel means.

@algitbot
Copy link

algitbot commented May 4, 2019

Merged in dbfcdae by @Ikke. Thanks for your contribution!

(This pull request has been closed automatically by GitHub PR Closer. If you think that it’s not resolved yet, please add a comment.)

@algitbot algitbot closed this May 4, 2019
algitbot pushed a commit that referenced this pull request May 4, 2019
Add myself as maintainer on i3status, and explicitly specify that it has
no test suite (when testing to make sure I could build locally, it
complained, so I confirmed that upstream doesn't ship any tests in the
current stable version).

Closes GH-7552
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R-testing Testing repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants