Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internet-explorer_9-11.svg is very large #201

Closed
eoghanmurray opened this issue Sep 13, 2021 · 4 comments
Closed

internet-explorer_9-11.svg is very large #201

eoghanmurray opened this issue Sep 13, 2021 · 4 comments

Comments

@eoghanmurray
Copy link
Contributor

eoghanmurray commented Sep 13, 2021

This SVG includes lots of unnecessary embedded .png dumps to achieve things which can be done with SVG filters etc.

https://github.com/alrra/browser-logos/blob/main/src/archive/internet-explorer_9-11/internet-explorer_9-11.svg

For an idea of the size reduction potential; removing them gets the filesize from 647KB to 77KB albeit with a bit of work to do to get the thing looking correct.

Would a redraw be accepted or is this an official SVG?

@alrra
Copy link
Owner

alrra commented Sep 13, 2021

This SVG includes lots of unnecessary embedded .png dumps to achieve things which can be done with SVG filters etc.

@eoghanmurray Yes. Unfortunately, when I last tried, I didn't managed to get something that didn't have very noticeable differences.

SVG filters

Note: SVG filters are not always the best when it comes to performance (see: [1], [2], [3]).

is this an official SVG?

It is. @docluv provided it for this project when he was working for or with Microsoft (see: #48).

Note: The .eps file is available in the pull request.

Would a redraw be accepted

As long as the differences are not very noticeable, yes!

Note: This project often improves upon the original, and where possible, the changes are contributed back to the source (e.g.: [1], [2], [3], etc.).


I'm going to close this issue, but as always, pull requests that improve things are very welcomed!

@alrra alrra closed this as completed Sep 13, 2021
@eoghanmurray
Copy link
Contributor Author

Thanks!

SVG filters are not always the best when it comes to performance

Suspected this at the back of my mind, but ignored it... good to see the references and I think actually some of the ones I did on the safari SVG could be replaced with radial gradients.

As long as the differences are not very noticeable, yes!

Is there a way of doing a diff and getting a 'score'?

@eoghanmurray
Copy link
Contributor Author

See #202

@alrra
Copy link
Owner

alrra commented Sep 17, 2021

Is there a way of doing a diff and getting a 'score'?

@eoghanmurray Yes. See for example: butteraugli.

@alrra alrra changed the title ie_9-11 SVG very large internet-explorer_9-11 is very large Sep 17, 2021
@alrra alrra changed the title internet-explorer_9-11 is very large internet-explorer_9-11.svg is very large Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants