New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redraw IE9 SVG to get from 600+KB to 8.5KB #202
Conversation
Original was 100x the file size. I'm comparing an export of this redraw against the 512x512px .png version and there's not much in it
@eoghanmurray Great work! Thank you for doing this! Here is the comparison view: At first glance 2 main differences stand out to me: |
@eoghanmurray You are getting really close! 👏 Here is the diff view: diff.mp4The darker yellow part of the ring still stands out as the main difference. Also, very minor things:
|
Ok loads more work done, basically redrew the 'swoosh' again, with probably about 6 complex and independent gradients rather than the 2 or 3 simpler ones in the previous version. Don't think I'm gonna get better than this as my reference .png is looking very close now; but maybe you have a different reference image which can uncover any further tweaks that are necessary? |
@eoghanmurray Thank you! 🙇♂️
Note: You can use GitHub to compare the differences. diff-view.mp4
What PNG are you using?
Note: In this repository the image without any dimensions included in the filename is the biggest one dimensionwise and the best one when it comes to details. In the case of IE 9-11, that image would be this one. For logos for which this project has the SVG, the SVG would be the best reference. As you previously notice, the PNG images are generated from the SVG. |
Was wondering how you generated the previous 'swipe' video!
I thought I noticed some serious artefacts in the prior SVG, as can be seen in this comparison: |
@eoghanmurray Could it be that the software (i.e.: Inkscape) you open the SVG in doesn't render it correctly? Try opening the SVG image in a browser? Here is the latest PNG and here is the latest SVG. I don't see any difference related to the blue background, and almost no difference overall: diff.mp4Note: I think the barely noticeable minor ring gradient differences come from resizing the SVG to be the same size as the PNG? Even though only lossless optimizations were done on |
Ah yes that was it! Previous version renders fine in certain sizes in the browser, but actually none of the gradients show when viewed raw. Also in Inkscape it doesn't render correctly which I didn't realize at the time. Good job I restarted comparing against the .png! So defo the new version I've done is much better I think! I'm attaching the 'full' Inkscape file in case anyone wants to use that for a further rework, which includes an embedded png for comparison, but otherwise the optimized SVG should be editable as I've labelled all the gradients/masks intelligibly. |
@eoghanmurray Yes, use the view inside of github.com or just open the files directly from your computer.
@eoghanmurray That is because on the raw page all the embedded images are blocked by the CSP policy. |
Any other issues before this can be accepted? |
@eoghanmurray Great work! 👏 Again, thank you for working on this! I've merged this PR in b26528e. |
Also, regenerate the PNG images based on the SVG. Ref: #202
Also, regenerate the PNG images based on the SVG. Ref: #202
Also, regenerate the PNG images based on the SVG. Ref: #202
Also, regenerate the PNG images based on the SVG. Ref: #202
Also, regenerate the PNG images based on the SVG. Ref: #202
Original was 100x the file size.
I'm comparing an export of this redraw against the 512x512px .png version and there's not much in it