-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SDM845 out of Qualcomm folder and add C360 #70
Move SDM845 out of Qualcomm folder and add C360 #70
Conversation
Move Qualcomm/sdm845 to sdm845 which is now the proper driver name and the default sdm845.conf is actually a DragonBoard DB845c config, so move accordingly. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
LENOVO YOGA C630 has MultiMedia1 dai setup as primary Playback so add required HiFi configuration as well. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
The Qualcomm directory was added to make the configuration directory tree more descriptive. The string sdm845 string is not very descriptive, but Qualcomm/sdm845 path looks much better in my eyes. I am playing with an idea to make the lookups like udev does for block devices (by-id / by-path / by-uuid). So the driver / name redirection may be done via a symlink directory like for module names (ucm2/modules). We can change the lookups via ucm2/ucm.conf file now. It's not only against the Qualcomm drivers. I don't like the old Intel names (chtnau8824 for example) which may be moved to Intel/ subtree. It's on my to do list, I'll try to do this change when my time permits. If you keep the Qualcomm/sdm845 tree, I'll accept your change now (assuming that the module name lookup works for you). |
Yes, sdm845 as it is, is not very descriptive.. like any other SoC names, namespacing it with Vendor name sounds good to me! Am Okay with it, as long as we do not endup with using single ucm conf (specially for Qcom case) for multiple machines. |
@perexg unfortunately module lookups won't work if the driver is built in into the kernel. Or if the same driver covers multiple cards (like this PR). --- alsa-ucm-conf-1.2.4.orig/ucm2/ucm.conf
+++ alsa-ucm-conf-1.2.4/ucm2/ucm.conf
@@ -53,6 +53,10 @@ If.driver {
False {
Define.KernelModulePath "class/sound/card${CardNumber}/device/driver/module"
Define.KernelModule "$${sys:$KernelModulePath}"
+ UseCasePath.modulelongname {
+ Directory "module/${var:KernelModule}"
+ File "${CardLongName}.conf"
+ }
UseCasePath.module {
Directory "module"
File "${var:KernelModule}.conf" As for the monolithic kernel builds, would it be possible to have include e.g. |
Add support for 'ucm2/module/${KernelModule}/${CardLongName}.conf' paths. On Qualcomm platforms single module supports multiple sound cards. BugLink: alsa-project#70 Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
…ation tree Introduce ucm2/conf.d/ tree with symlinks to the real hardware configurations. In this way, we do not rely to create the configuration paths based on simple driver / device identification, but we can store the configurations more logically to make the maintenance (code reuse, multiple changes) more easy. BugLink: alsa-project#70 BugLink: alsa-project#76 BugLink: alsa-project#78 Signed-off-by: Jaroslav Kysela <perex@perex.cz>
…ation tree Introduce ucm2/conf.d/ tree with symlinks to the real hardware configurations. In this way, we do not rely to create the configuration paths based on simple driver / device identification, but we can store the configurations more logically to make the maintenance (code reuse, multiple changes) more easy. BugLink: alsa-project#70 BugLink: alsa-project#76 BugLink: alsa-project#78 Signed-off-by: Jaroslav Kysela <perex@perex.cz>
…ation tree Introduce ucm2/conf.d/ tree with symlinks to the real hardware configurations. In this way, we do not rely to create the configuration paths based on simple driver / device identification, but we can store the configurations more logically to make the maintenance (code reuse, multiple changes) more easy. BugLink: alsa-project#70 BugLink: alsa-project#76 BugLink: alsa-project#78 Signed-off-by: Jaroslav Kysela <perex@perex.cz>
…ation tree Introduce ucm2/conf.d/ tree with symlinks to the real hardware configurations. In this way, we do not rely to create the configuration paths based on simple driver / device identification, but we can store the configurations more logically to make the maintenance (code reuse, multiple changes) more easy. BugLink: alsa-project#70 BugLink: alsa-project#76 BugLink: alsa-project#78 Signed-off-by: Jaroslav Kysela <perex@perex.cz>
…ation tree Introduce ucm2/conf.d/ tree with symlinks to the real hardware configurations. In this way, we do not rely to create the configuration paths based on simple driver / device identification, but we can store the configurations more logically to make the maintenance (code reuse, multiple changes) more easy. This commit keeps the older lookup paths active, but they will be turned off in the next release. BugLink: #70 BugLink: #76 BugLink: #78 Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Obsoleted by 90ee4e0 . EDIT: Create another PR for C360. Thank you. |
…ation tree Introduce ucm2/conf.d/ tree with symlinks to the real hardware configurations. In this way, we do not rely to create the configuration paths based on simple driver / device identification, but we can store the configurations more logically to make the maintenance (code reuse, multiple changes) more easy. This commit keeps the older lookup paths active, but they will be turned off in the next release. BugLink: alsa-project#70 BugLink: alsa-project#76 BugLink: alsa-project#78 Signed-off-by: Jaroslav Kysela <perex@perex.cz>
With driver_name fix in sdm845 machine driver https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.10&id=3f48b6eba15ea342ef4cb420b580f5ed6605669f
/proc/asound/cards get populated correctly with proper driver name and card long name. With this in place we should be able to rearrange sdm845 directory to be inline with others and reuse some of the common code.
Without this all the sdm845 based machines will get a generic ucm description which will not work, one of such instance is Lenovo C360 Laptop. This patchset also add support to Lenovo C360 support
Thanks,
srini