ucm2: Separate the configuration lookups (hw based) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perexg
force-pushed
the
conf-d
branch
2 times, most recently
from
cfb86a8
to
7d9a8b0
Compare
…ation tree Introduce ucm2/conf.d/ tree with symlinks to the real hardware configurations. In this way, we do not rely to create the configuration paths based on simple driver / device identification, but we can store the configurations more logically to make the maintenance (code reuse, multiple changes) more easy. BugLink: alsa-project#70 BugLink: alsa-project#76 BugLink: alsa-project#78 Signed-off-by: Jaroslav Kysela <perex@perex.cz>
lumag
reviewed
Feb 3, 2021
| Directory "conf.d/${var:Driver}" | ||
| File "${CardLongName}.conf" | ||
| } | ||
| UseCasePath.driver { |
There was a problem hiding this comment.
This will conflict with the False.UseCasePath -> driver below, won't it?
There was a problem hiding this comment.
ok, ignore this comment please.
lumag
reviewed
Feb 3, 2021
| } | ||
| True.Define { | ||
| KernelDriverPath "class/sound/card${CardNumber}/device/driver" | ||
| Driver "${sys:$KernelDriverPath}" |
lumag
reviewed
Feb 3, 2021
| # ucm2/${CardDriver}/${CardLongName}.conf | ||
| # ucm2/${CardDriver}/${CardDriver}.conf | ||
| # ucm2/conf.d/[${CardDriver}|${KernelDriver}]/${CardLongName}.conf | ||
| # ucm2/conf.d/[${CardDriver}|${KernelDriver}]/[${CardDriver}|${KernelDriver}].conf |
There was a problem hiding this comment.
Could you please point, how is the ${CardDriver} handled? In your code I see only ucm2/conf.d/${KernelDriver}/${CardLongName}.conf and ucm2/conf.d/${KernelDriver}/${KernelDriver}.conf
|
Tested on Qualcomm boards, works perfectly: Linaro/meta-qcom@2adcb49#diff-b634ac912c308ac65f0bd24b4606466c7a8142316d8dba5292634e6f9e8bcff5 |
|
Merged in 4cfceb1 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce ucm2/conf.d/ tree with symlinks to the real hardware configurations.
In this way, we do not rely to create the configuration paths based on
simple driver / device identification, but we can store the configurations
more logically to make the maintenance (code reuse, multiple changes)
more easy.
BugLink: #70
BugLink: #76
BugLink: #78