Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH 00/15] protocols/fireface: implements traits to cache/update parameters specific to former models #148

Merged
merged 15 commits into from
Mar 8, 2023

Conversation

takaswie
Copy link
Member

@takaswie takaswie commented Mar 8, 2023

This patchset provides common interface to cache/update parameters specific to former models, including serializer/deserializer for the parameters..

Takashi Sakamoto (15):
  protofols/fireface: add trait and its implementation for specification
    in former models
  protocols/fireface: implement trait to deserialize meter state in
    former model
  protocols/fireface: implement trait to cache meter state in former
    models
  runtime/fireface: use alternative way to cache meter state in former
    models
  protocols/fireface: implement trait to serialize/deserialize mixer
    parameters in former models
  protocols/fireface: implement trait to update mixer wholly in former
    models
  protocols/fireface: add trait to update the part of parameters after
    comparing the content
  protocols/fireface: implement trait to update mixer parameters
    partially in former models
  runtime/fireface: use alternative way to update mixer in former models
  protocols/fireface: implement trait to serialize/deserialize output
    parameters in former models
  protocols/fireface: implement trait to update output volumes
    wholly/partially in Fireface 800
  protocols/fireface: implement trait to update output volumes
    wholly/partially in Fireface 400
  runtime/fireface: use alternative way to update output volumes in
    former models
  protocols/fireface: implement trait to update input gains
    wholly/partially in Fireface 400
  runtime/fireface: use alternative way to update input gains in
    Fireface 400

 protocols/fireface/src/former.rs       | 559 +++++++++++++++++--------
 protocols/fireface/src/former/ff400.rs | 240 ++++++-----
 protocols/fireface/src/former/ff800.rs |  91 ++--
 protocols/fireface/src/latter.rs       |   6 -
 protocols/fireface/src/lib.rs          |  11 +
 runtime/fireface/src/ff400_model.rs    |  38 +-
 runtime/fireface/src/former_ctls.rs    | 150 +++----
 7 files changed, 653 insertions(+), 442 deletions(-)

…n in former models

Each former model has specification about I/O. The specification is
available for each functions; e.g. the number of physical inputs for
mixer.

This commit adds trait and its implementations to express the
specification.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
…mer model

This commit implements serializer and deserializer for meter registers
in former models.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
…dels

This commit implements the trait to cache meter parameters wholly at once
for former models.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
…models

The trait implementation is available to cache meter parameters for
former models. This commit uses it and obsoletes the previous
implementation.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
…rameters in former models

This commit implements serializer and deserializer for mixer registers
in former models.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
…models

This commit implements the trait to update mixer parameters wholly for
former models.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
…comparing the content

This commit adds a trait in which given two parameters are compared and
hardware is updated if any change is found.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
…lly in former models

This commit implements the trait to update mixer parameters partially for
former models.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
The trait implementation is available to update mixer parameters for
former models. This commit uses it and obsoletes the previous
implementation.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
…arameters in former models

This commit implements serializer and deserializer for output registers
in former models.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
…artially in Fireface 800

This commit implements the trait to update output volumes parameters
wholly and partially for Fireface 800

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
…artially in Fireface 400

This commit implements the trait to update output volumes parameters
wholly and partially for Fireface 400

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
…mer models

The trait implementation is available to update output volume parameters
for former models. This commit uses it and obsoletes the previous
implementation.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
…ially in Fireface 400

This commit implements the trait to update input gains parameters wholly
and partially for Fireface 400.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
…ce 400

The trait implementation is available to update input gains parameters
for Fireface 400. This commit uses it and obsoletes the previous
implementation.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
@takaswie takaswie added the enhancement New feature or request label Mar 8, 2023
@takaswie takaswie requested a review from a team March 8, 2023 08:00
@takaswie takaswie self-assigned this Mar 8, 2023
@takaswie takaswie merged commit 04b3ec7 into master Mar 8, 2023
@takaswie takaswie deleted the topic/ff/rework-former-dsp branch March 8, 2023 22:19
@takaswie
Copy link
Member Author

takaswie commented Mar 8, 2023

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant