Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (long live) env dynamic in docker container #5

Closed
wants to merge 8 commits into from
Closed

feat: (long live) env dynamic in docker container #5

wants to merge 8 commits into from

Conversation

alswl
Copy link
Owner

@alswl alswl commented Nov 5, 2023 •
edited
Loading

Problem: nodejs app env should rebuild when env changes.

Solution:

  1. using window._env_ instead of process.env
  2. using launcher.py to launch app, the Python script will update window._env_ values.

@alswl alswl changed the title Feat/env dynamic in docker container fix: env dynamic in docker container Nov 5, 2023
@alswl alswl changed the title fix: env dynamic in docker container feat: env dynamic in docker container Nov 5, 2023
@alswl alswl mentioned this pull request Nov 5, 2023
Closed
@alswl alswl changed the base branch from fork to master November 5, 2023 15:59
@alswl alswl force-pushed the feat/env-dynamic-in-docker-container branch from be51fa2 to b87f017 Compare November 5, 2023 16:15
@alswl alswl changed the title feat: env dynamic in docker container feat: (long live) env dynamic in docker container Nov 5, 2023
@alswl alswl mentioned this pull request Nov 10, 2023
Merged
@alswl alswl force-pushed the feat/env-dynamic-in-docker-container branch 2 times, most recently from 6949e42 to 40fceaa Compare November 11, 2023 10:36
@alswl alswl force-pushed the feat/env-dynamic-in-docker-container branch from 40fceaa to 7b88aa9 Compare November 11, 2023 11:17
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 74.48% / 70% 42103 / 56527
🟢 Statements 74.48% / 70% 42103 / 56527
🟢 Functions 69.77% / 68% 1341 / 1922
🟢 Branches 80.8% / 70% 5196 / 6430
File CoverageNo changed files found.
Generated in workflow #1

@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/excalidraw.production.min.js 295.01 KB (0%) 6 s (0%) 416 ms (-9.83% 🔽) 6.4 s
dist/excalidraw-assets/locales 261.47 KB (0%) 5.3 s (0%) 114 ms (-19.03% 🔽) 5.4 s
dist/excalidraw-assets/vendor*.js 28.06 KB (0%) 562 ms (0%) 128 ms (+67.01% 🔺) 690 ms

@xvbai0317 xvbai0317 mentioned this pull request Dec 12, 2023
Open
This was referenced Jan 21, 2024
Closed
Closed
@Hanxiaoyi2016 Hanxiaoyi2016 mentioned this pull request Feb 20, 2024
Open
@pope-L pope-L mentioned this pull request Mar 7, 2024
Closed
@alswl alswl closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alswl