Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using dynamic env launcher instead of pre build image #33

Merged
merged 4 commits into from
Nov 11, 2023
Merged

Using dynamic env launcher instead of pre build image #33

merged 4 commits into from
Nov 11, 2023

Conversation

alswl
Copy link
Owner

@alswl alswl commented Nov 10, 2023

Remove make image stage, and use dynamic launcher for excalidraw.

The forked excalidraw feature is alswl/excalidraw#5

The solution is

  • using window.env instead of process.env
  • using launcher.py to launch app, the Python script will update window.env values.

related to

block

@alswl
Copy link
Owner Author

alswl commented Nov 11, 2023

Solve #7

unblock #32

@alswl alswl merged commit 090283e into master Nov 11, 2023
@alswl alswl deleted the feat/dynamic-env-launcher branch November 11, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alswl