Skip to content
This repository has been archived by the owner on Sep 9, 2023. It is now read-only.

Watcher does not reset on ticker event #90

Closed
aurecchia opened this issue Aug 5, 2019 · 3 comments · Fixed by #91
Closed

Watcher does not reset on ticker event #90

aurecchia opened this issue Aug 5, 2019 · 3 comments · Fixed by #91
Labels
fix-me Something isn't working

Comments

@aurecchia
Copy link
Contributor

Exchange
All exchanges that support tickers

Subscription type
ticker

Describe the bug
The last update time kept internally in the watcher is not updated on ticker events, therefore clients that only subscribe to those are reconnected every 90 seconds.

To Reproduce

  1. Connect to the ticker event with a client that supports that (e.g. the Bittrex one)
  2. Wait for 90 seconds
  3. The watcher logs info: watcher initiating reconnection then disconnects and reconnects the client.

Expected behavior
The client connection should be kept alive by ticker messages as well

Additional context
I'll provide a PR to fix the issue. In case this behaviour was intentional, I'll find a way around the problem :)

@bmancini55
Copy link
Member

Thanks! That looks like a bug. If you would like to submit a PR that would be fantastic!

@bmancini55 bmancini55 added the fix-me Something isn't working label Aug 5, 2019
@bmancini55
Copy link
Member

Released in v0.26.3, thanks!

@aurecchia
Copy link
Contributor Author

Thank you for the quick reply as usual! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix-me Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants