Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript types #7

Open
torkelrogstad opened this issue Aug 4, 2018 · 2 comments
Open

TypeScript types #7

torkelrogstad opened this issue Aug 4, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@torkelrogstad
Copy link

torkelrogstad commented Aug 4, 2018

There's no typings for this package. Is that something that would be desired? If so, I could take a stab at implementing them.

I understand that the methods exposed after lnd.connect() aren't implemented in this package, and that this package is just really a somewhat thin wrapper around gRPC calls. However, I believe it is possible to write types for the gRPC calls, meaning that it would be possible to interact with lnd API calls, and have the TypeScript compiler/your IDE tell you what the response contains.

@bmancini55 bmancini55 added the enhancement New feature or request label Aug 5, 2018
@bmancini55
Copy link
Member

Absolutely, I think that would be a great addition. Especially if the gRPC protocol definitions can be mapped out.

@torkelrogstad
Copy link
Author

I've actually started on writing out the gRPC types, but it's quite tedious. Is there some tool out there for extracting it from proto files? It probably won't be 100% correct, but it would be a good starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants