Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable matrix entries #34

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

Reusable matrix entries #34

wants to merge 34 commits into from

Conversation

altendky
Copy link
Owner

@altendky altendky commented Feb 7, 2021

Draft for:

  • Make it actually work
  • Formalize the script (a separate project?)
  • A test to verify the generated workflow is up to date
  • Retarget to main branch after Freeze with PyInstaller #30 is merged
  • Dedupe the names as well...

@codecov
Copy link

codecov bot commented Feb 7, 2021

Codecov Report

Merging #34 (6cccc21) into main (ab991de) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          595       595           
  Branches        43        43           
=========================================
  Hits           595       595           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab991de...6cccc21. Read the comment docs.

@altendky
Copy link
Owner Author

altendky commented Feb 8, 2021

So after spending a few hours figuring out 7b8eeb3, I gave in and concluded that _something_ needed to be different. This repetition of the matrix entries is just crazy (this isn't the only repository I deal with it in...). My first attempt was to do some silly matrix games and generate output from one job and reference in the next and.... *ugh* I've already done this (because it was really needed) in https://github.com/altendky/romp in Azure Pipelines but I couldn't quite get it to work here. Used this page for a bit of reference.

So the underlying problem is GitHub Actions hasn't gotten around to YAML anchors.
https://github.community/t/support-for-yaml-anchors/16128

Anyways, the present implementation here involves just writing a workflow with anchors and then running it through some python/pyyaml to resolve and duplicate the anchors to make GitHub Actions happy.

@altendky altendky changed the base branch from main to pyinstaller February 8, 2021 03:17
Base automatically changed from pyinstaller to main February 9, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant