-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split xdefaults out into light/dark modes #22
Comments
Please elaborate on this and/or document how to it is supposed to be installed? Just drop the contents of https://github.com/altercation/solarized/blob/master/xresources-colors-solarized/Xresources into ~/.Xdefaults? I am getting mixed results using this method with urxvt. |
I need to update the Xdefaults. I'll do so and include a README and Ethan Schoonover On Fri, Apr 8, 2011 at 13:42, blueyed
|
hopefully if I comment on this, I'll get notified when this issue is closed chalk this up to a "+1, xdefaults needs fixing" |
Sent a pull request to fix the colors as they are. I have another commit that splits into light and dark, but github can't handle multiple pull requests I guess, so I have to wait for you to accept the first one or something. |
@adlaiff6 You can have a pull-request per branch. |
@adamv thanks, that's interesting, I'll look in to it later |
I took a different approach, and used the cpp #ifdef conditionals to choose between light/dark in the same file. Pull request submitted, what do you guys think? |
Checking this out. Will feedback. |
Closing this and will follow up this issue in the pull request: |
This also removes the `solarized-termcolors` custom variable, as we now try to detect the number of terminal colors automatically. Hopefully, this fixes issues altercation#22, altercation#30, and altercation#54.
No description provided.
The text was updated successfully, but these errors were encountered: