Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split xdefaults out into light/dark modes #22

Closed
altercation opened this issue Apr 5, 2011 · 10 comments
Closed

Split xdefaults out into light/dark modes #22

altercation opened this issue Apr 5, 2011 · 10 comments
Labels

Comments

@altercation
Copy link
Owner

No description provided.

@blueyed
Copy link

blueyed commented Apr 8, 2011

Please elaborate on this and/or document how to it is supposed to be installed?

Just drop the contents of https://github.com/altercation/solarized/blob/master/xresources-colors-solarized/Xresources into ~/.Xdefaults?

I am getting mixed results using this method with urxvt.

@altercation
Copy link
Owner Author

I need to update the Xdefaults. I'll do so and include a README and
will comment here after it's in.

Ethan Schoonover
es@ethanschoonover.com
http://ethanschoonover.com

On Fri, Apr 8, 2011 at 13:42, blueyed
reply@reply.github.com
wrote:

Please elaborate on this and/or document how to it is supposed to be installed?

Just drop the contents of https://github.com/altercation/solarized/blob/master/xresources-colors-solarized/Xresources into ~/.Xdefaults?

I am getting mixed results using this method.

Reply to this email directly or view it on GitHub:
#22 (comment)

@leifwalsh
Copy link

hopefully if I comment on this, I'll get notified when this issue is closed

chalk this up to a "+1, xdefaults needs fixing"

@leifwalsh
Copy link

Sent a pull request to fix the colors as they are. I have another commit that splits into light and dark, but github can't handle multiple pull requests I guess, so I have to wait for you to accept the first one or something.

@adamv
Copy link
Contributor

adamv commented Apr 12, 2011

@adlaiff6 You can have a pull-request per branch.

@leifwalsh
Copy link

@adamv thanks, that's interesting, I'll look in to it later

@dgoodlad
Copy link

I took a different approach, and used the cpp #ifdef conditionals to choose between light/dark in the same file. Pull request submitted, what do you guys think?

@altercation
Copy link
Owner Author

Checking this out. Will feedback.

@altercation
Copy link
Owner Author

Closing this and will follow up this issue in the pull request:
#49

@ghost
Copy link

ghost commented Aug 31, 2012

#68

xnox pushed a commit to xnox/solarized that referenced this issue Sep 9, 2012
This also removes the `solarized-termcolors` custom variable, as we now try to detect the number of terminal colors automatically.

Hopefully, this fixes issues altercation#22, altercation#30, and altercation#54.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants