Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Lowest and Highest when Binning #114

Closed
jeff-hernandez opened this issue Apr 9, 2020 · 1 comment · Fixed by #133
Closed

Include Lowest and Highest when Binning #114

jeff-hernandez opened this issue Apr 9, 2020 · 1 comment · Fixed by #133
Labels
enhancements Improvement to an existing feature

Comments

@jeff-hernandez
Copy link
Collaborator

jeff-hernandez commented Apr 9, 2020

In the bin transform, there should be parameters to include the lowest and/or highest values when binning. This can be done by adding either infinite or min/max values of the target as endpoints in the bins. An example in the docstrings should show how to use this new parameter.

@jeff-hernandez jeff-hernandez added the enhancements Improvement to an existing feature label Apr 9, 2020
@jeff-hernandez jeff-hernandez changed the title Include Lowest when Binning Include Lowest and Highest when Binning May 1, 2020
@jeff-hernandez
Copy link
Collaborator Author

The include lowest in pandas cut will set whether the first interval should be left-inclusive or not. This is different from what we want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements Improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant