Rename LabelTimes.name to LabelTimes.label_name #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 845 845
=========================================
Hits 845 845
|
|
Since this is renaming a public attribute we should mention this as a breaking change in the changelog |
kmax12
previously approved these changes
Apr 20, 2020
There was a problem hiding this comment.
The API change is good with me. I'll leave it to @jeff-hernandez and @rwedge to make sure the code checks out
rwedge
reviewed
Apr 20, 2020
jeff-hernandez
requested changes
Apr 20, 2020
There was a problem hiding this comment.
The cell 16 in this notebook needs to be updated.
y = fm.pop(lt.name)Otherwise, looks good to merge.
jeff-hernandez
approved these changes
Apr 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
nameattribute onLabelTimestolabel_nameto avoidTypeErrorwhen converting to a Dask dataframeResolves #125