Skip to content

Commit

Permalink
Merge branch 'main' into bc_fix_notebooks
Browse files Browse the repository at this point in the history
  • Loading branch information
bchen1116 committed Jan 5, 2021
2 parents 00fe8b3 + 84b0214 commit 2ba54cf
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 2 deletions.
1 change: 1 addition & 0 deletions docs/source/release_notes.rst
Expand Up @@ -15,6 +15,7 @@ Release Notes
* Fixed AutoMLSearch stacktrace when a cutom objective was passed in as a primary objective or additional objective :pr:`1575`
* Limit ``load_fraud`` dataset loaded into ``automl.ipynb`` :pr:`1646`
* Fix custom index bug for ``MAPE`` objective :pr:`1641`
* Fixed bug where time series baseline estimators were not receiving ``gap`` and ``max_delay`` in ``AutoMLSearch`` :pr:`1645`
* Changes
* Documentation Changes
* Updated docs to include information about ``AutoMLSearch`` callback parameters and methods :pr:`1577`
Expand Down
3 changes: 2 additions & 1 deletion evalml/automl/automl_search.py
Expand Up @@ -623,7 +623,8 @@ def _add_baseline_pipelines(self):
else:
gap = self.problem_configuration['gap']
max_delay = self.problem_configuration['max_delay']
baseline = TimeSeriesBaselineRegressionPipeline(parameters={"pipeline": {"gap": gap, "max_delay": max_delay}})
baseline = TimeSeriesBaselineRegressionPipeline(parameters={"pipeline": {"gap": gap, "max_delay": max_delay},
"Time Series Baseline Regressor": {"gap": gap, "max_delay": max_delay}})
pipelines = [baseline]
scores = self._evaluate_pipelines(pipelines, baseline=True)
if scores == []:
Expand Down
14 changes: 14 additions & 0 deletions evalml/tests/automl_tests/test_automl.py
Expand Up @@ -2032,3 +2032,17 @@ def test_automl_data_splitter_consistent(mock_binary_score, mock_binary_fit, moc
assert data_splitters[0] == data_splitters[1]
assert data_splitters[1] != data_splitters[2]
assert data_splitters[2] == data_splitters[3]


@patch('evalml.pipelines.TimeSeriesRegressionPipeline.fit')
@patch('evalml.pipelines.TimeSeriesRegressionPipeline.score')
def test_timeseries_baseline_init_with_correct_gap_max_delay(mock_fit, mock_score, X_y_regression):

X, y = X_y_regression
automl = AutoMLSearch(X_train=X, y_train=y, problem_type="time series regression",
problem_configuration={"gap": 6, "max_delay": 3}, max_iterations=1)
automl.search()

# Best pipeline is baseline pipeline because we only run one iteration
assert automl.best_pipeline.parameters == {"pipeline": {"gap": 6, "max_delay": 3},
"Time Series Baseline Regressor": {"gap": 6, "max_delay": 3}}
Expand Up @@ -10,7 +10,7 @@ lightgbm==3.1.1
matplotlib==3.3.3
networkx==2.5
nlp-primitives==1.1.0
numpy==1.19.4
numpy==1.19.5
pandas==1.1.5
plotly==4.14.1
psutil==5.8.0
Expand Down

0 comments on commit 2ba54cf

Please sign in to comment.