Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old datasplitters #2099

Closed
bchen1116 opened this issue Apr 6, 2021 · 1 comment · Fixed by #2193
Closed

Remove old datasplitters #2099

bchen1116 opened this issue Apr 6, 2021 · 1 comment · Fixed by #2193
Assignees
@bchen1116
Labels
task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug.

Comments

@bchen1116
Copy link
Contributor

with #2098 and #2014, we add oversampling/undersampling support to AutoML. Since we decide to do sampling after feature generation, our previous PR that added sampling data splitters is no longer needed. We can delete these old samplers.
@dsherry dsherry added the task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug. label Apr 6, 2021
@dsherry
Copy link
Contributor

dsherry commented Apr 6, 2021 •
edited

Good call, agreed!

I threw this into #2036 , hope that's ok with you @bchen1116

@dsherry dsherry mentioned this issue Apr 6, 2021
Closed
@bchen1116 bchen1116 mentioned this issue Apr 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bchen1116 bchen1116

Labels
task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the old datasplitters from EvalML alteryx/evalml
2 participants
@dsherry @bchen1116