Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_catch_warnings suppresses non-ParameterNotUsed warnings #2761

Closed
eccabay opened this issue Sep 9, 2021 · 0 comments · Fixed by #2765
Closed

_catch_warnings suppresses non-ParameterNotUsed warnings #2761

eccabay opened this issue Sep 9, 2021 · 0 comments · Fixed by #2765
Assignees
@eccabay

Comments

@eccabay
Copy link
Contributor

eccabay commented Sep 9, 2021

PR #2753 fixed a bug where non-ParameterNotUsed warnings would break _catch_warnings, a method originally designed to collapse multiple ParameterNotUsed warnings into a single warning. However, a side effect of this was that any other types of warnings thrown in this section of code are now caught but never re-raised.

Some discussion of this from here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eccabay eccabay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raise all warnings in _catch_warnings alteryx/evalml
1 participant
@eccabay