Raise all warnings in _catch_warnings
#2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2765 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 301 301
Lines 27889 27904 +15
=======================================
+ Hits 27826 27841 +15
Misses 63 63
Continue to review full report at Codecov.
|
jeremyliweishih
approved these changes
Sep 10, 2021
bchen1116
requested changes
Sep 13, 2021
| @@ -5102,6 +5102,25 @@ def test_pipeline_parameter_warnings_only_parameternotused( | |||
| assert str(warning) == "Big bad warning" | |||
|
|
|||
|
|
|||
| def test_pipeline_parameter_warnings_with_other_types(): | |||
There was a problem hiding this comment.
Is there test coverage on if we get multiple warnings with the same message? ie coverage for
elif str(msg.message) not in raised_messages:
warnings.warn(msg.message)
raised_messages.append(str(msg.message))?
There was a problem hiding this comment.
Yep, this test covers that! The TargetLeakage warning actually throws the same warning for each generated pipeline, just like the ParameterNotUsed warnings come up. This test is actually how I discovered we needed to filter duplicate warnings.
bchen1116
approved these changes
Sep 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2761