Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have dependency check bot install same requirements as latest dependency checkin job #576

Closed
dsherry opened this issue Apr 2, 2020 · 0 comments · Fixed by #578
Closed
Assignees
Labels
blocker An issue blocking a release. bug Issues tracking problems with existing features.

Comments

@dsherry
Copy link
Contributor

dsherry commented Apr 2, 2020

Problem
Right now, dependency check bot (which uses github actions) installs core-requirements.txt and requirements.txt but not test-requirements.txt like latest_dependency_check does in the checkin tests.

Fix
We should update these to match, otherwise we'll get problems when we add things to the test reqs.

While we're at it, let's centralize all pip commands into the makefile so that we don't run into this sort of issue again.

Remove category-encoders for whitelist and latest_dependecies.txt

Marked as a blocker because we should fix this before merging more stuff to master to avoid confusion lol

@dsherry dsherry added blocker An issue blocking a release. bug Issues tracking problems with existing features. labels Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker An issue blocking a release. bug Issues tracking problems with existing features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants