Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar when only searching for one pipeline is confusing #609

Closed
kmax12 opened this issue Apr 9, 2020 · 4 comments · Fixed by #921
Closed

Progress bar when only searching for one pipeline is confusing #609

kmax12 opened this issue Apr 9, 2020 · 4 comments · Fixed by #921
Labels
enhancement An improvement to an existing feature.
Milestone

Comments

@kmax12
Copy link
Contributor

kmax12 commented Apr 9, 2020

To help me debug, I was running automl search with just one pipeline. When I look at the output, it makes feel as if the search is already complete since I see the 100%. Minor issue, but perhaps we can clean up the output

Screen Shot 2020-04-09 at 12 45 34 PM

@dsherry dsherry added the enhancement An improvement to an existing feature. label Apr 13, 2020
@dsherry
Copy link
Contributor

dsherry commented Apr 13, 2020

+1. In the edge case you're describing, where we're only searching one pipeline, we could have the cmdline progress bar show 0% before the pipeline is fitted and 100% after.

But I agree we could also simply omit the progress bar entirely when there's only one pipeline.

@jeremyliweishih
Copy link
Collaborator

Related to #245. From what I remember from my experimentation that there wasn't a perfect fix - each implementation resulted in some edge case being off. IIRC I couldn't fix this behavior (new line with new pipeline uses next percentage i.e only pipeline starts with 100%) as the alternative would be for the next pipeline to retain the same percentage which is confusing in another way (i.e first pipeline hits 50% and the next will keep 50% until finished). Might be worth brainstorming options other than TQDM.

@dsherry
Copy link
Contributor

dsherry commented Apr 15, 2020

@jeremyliweishih agreed. I think we should move off TQDM. Will reorganize these tickets soon. For the moment let's hold off on working on TQDM-related issues.

@dsherry
Copy link
Contributor

dsherry commented May 8, 2020

#761 will fix this, keeping it open until then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants