-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update automl search API: AutoMLSearch class #825
Comments
Thanks @SydneyAyx ! This is great feedback to have. I agree this is nonintuitive and that we can improve it. The reason this usage triggers an error is that the provided data is multiclass but the The objective and problem type are set in Options which come to mind:
I'm split between options 1 and 2. I don't feel great about options 3 or 4. @kmax12 what do you think? |
Looking at this and #826 again, here's what I'd like us to do:
|
rather than have 3 different class that are so long in name, what if we had one class with a required problem_type argument? # could use enum instead, but i bet most users wouldn't
AutoMLSearch(problem_type="regression")
AutoMLSearch(problem_type="binary")
AutoMLSearch(problem_type="multiclass") if a user has to look up to know the name of the complicated class, they can look up the parameter. I also think this structure better presents what is going on. The searches are more similar than different, which was part of the motivation for lumping binary and multiclass together in the first place. this also sets us up better in the future if we don't want to make problem type required. The dynamic pipeline in #841 will make this change eaiser, since we dont have to determine the pipelines at init any more. since, we're trying to tackle this this month, lmk if talking live would be better |
That's a cool idea @kmax12 . That could be a nice simplification over what we have now. Yeah, since this API is the first thing most users will see, let's take some time and talk it over. I just sent you and @ctduffy an invite for Tues afternoon. Worth noting that if the scope creeps on this, we may wanna get a short-term fix in for June and file the API update as a separate issue. |
@ctduffy @kmax12 and I just met to discuss. Here's our notes. Next steps
|
@ctduffy and I synced an hour ago. The design doc is done! Next step is @ctduffy is going to make an epic for this and #826 , and we'll get this issue done for the June milestone and the rest for July. We estimated this issue will take 6 days to complete. So we have just enough time to get it done before the June release on Tues the 30th. |
Instantiating AutoClassificationSearch() without specifying Multiclass=True and not providing an objective results in an error.
Code to reproduce:
The error message is clear and this is super easy to work around, but it is probably not the expected behavior for a user trying to use defaults and auto-model in easy mode.
The text was updated successfully, but these errors were encountered: