Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move permutation importance from evalml/pipeline/utils.py to graph_utils.py #875

Closed
dsherry opened this issue Jun 23, 2020 · 1 comment · Fixed by #880
Closed

Move permutation importance from evalml/pipeline/utils.py to graph_utils.py #875

dsherry opened this issue Jun 23, 2020 · 1 comment · Fixed by #880
Assignees
@angela97lin
Labels
refactor Work being done to refactor code.
Milestone
June 2020

Comments

@dsherry
Copy link
Contributor

dsherry commented Jun 23, 2020

Hey @angela97lin I was just opening up my demo notebook to take a look at the permutation importance stuff and I noticed its in evalml/pipeline/utils.py. I think evalml/pipeline/graph_utils.py would be a more appropriate location to move this stuff before the release, since that's where we currently put other graphs like confusion matrix. That sound ok to you?
@dsherry dsherry added the refactor Work being done to refactor code. label Jun 23, 2020
@dsherry dsherry added this to the June 2020 milestone Jun 23, 2020
@angela97lin
Copy link
Contributor

@dsherry Yup, sounds good, will do!

@angela97lin angela97lin mentioned this issue Jun 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angela97lin angela97lin

Labels
refactor Work being done to refactor code.
Projects
None yet
Milestone
June 2020
Development

Successfully merging a pull request may close this issue.

Moves permutation importance from evalml/pipeline/utils.py to graph_utils.py alteryx/evalml
2 participants
@dsherry @angela97lin