Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Additional Regression Objectives #100

Merged
merged 18 commits into from
Oct 21, 2019
Merged

Conversation

christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Sep 24, 2019

Addresses #32 by adding in all of the scikit-learn supported metrics for regression, including:

  • Mean Squared Error
  • Max Error
  • Explained Variance
  • Mean Squared Log Error
  • Median Absolute Error
  • Mean Absolute Error

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #100 into master will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   94.13%   94.32%   +0.18%     
==========================================
  Files          58       58              
  Lines        1467     1516      +49     
==========================================
+ Hits         1381     1430      +49     
  Misses         86       86
Impacted Files Coverage Δ
evalml/objectives/utils.py 100% <ø> (ø) ⬆️
evalml/utils/__init__.py 100% <100%> (ø) ⬆️
evalml/objectives/standard_metrics.py 100% <100%> (ø) ⬆️
evalml/tests/objective_tests/test_objectives.py 100% <100%> (ø) ⬆️
evalml/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0470b...5589f75. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, what do you think @kmax12?

Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add these to the API reference as well. otherwise, looks good

kmax12
kmax12 previously approved these changes Oct 10, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last comment from me, otherwise looks good

kmax12
kmax12 previously approved these changes Oct 17, 2019
needs_fitting = False
greater_is_better = False
need_proba = False
name = "MedAE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make name MedianAe to be consistent?

kmax12
kmax12 previously approved these changes Oct 21, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherbunn christopherbunn merged commit 8f0ce81 into master Oct 21, 2019
@christopherbunn christopherbunn deleted the addl-reg-metrics branch October 21, 2019 19:01
@christopherbunn christopherbunn restored the addl-reg-metrics branch October 23, 2019 16:42
@angela97lin angela97lin mentioned this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants