Add component save/load; add protocol argument to all save/load #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherry
commented
Aug 5, 2020
Codecov Report
@@ Coverage Diff @@
## main #1023 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 181 181
Lines 9631 9690 +59
=======================================
+ Hits 9622 9681 +59
Misses 9 9
Continue to review full report at Codecov.
|
gsheni
reviewed
Aug 5, 2020
angela97lin
reviewed
Aug 5, 2020
dsherry
commented
Aug 5, 2020
| assert component.parameters == loaded_component.parameters | ||
| assert component.describe(return_dict=True) == loaded_component.describe(return_dict=True) | ||
| if issubclass(component_class, Estimator): | ||
| assert (component.feature_importance == loaded_component.feature_importance).all() |
There was a problem hiding this comment.
@angela97lin thanks for the suggestion. This test now runs on every component / serialization protocol
gsheni
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #821
Here's the doc on datastream protocols supported in
pickle.