Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component save/load; add protocol argument to all save/load #1023

Merged
merged 6 commits into from Aug 5, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Aug 5, 2020

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #1023 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1023   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files         181      181           
  Lines        9631     9690   +59     
=======================================
+ Hits         9622     9681   +59     
  Misses          9        9           
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.55% <100.00%> (ø)
evalml/pipelines/components/component_base.py 100.00% <100.00%> (ø)
evalml/pipelines/pipeline_base.py 100.00% <100.00%> (ø)
evalml/tests/automl_tests/test_automl.py 100.00% <100.00%> (ø)
evalml/tests/component_tests/test_components.py 99.59% <100.00%> (+0.02%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1860c2...376c141. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Maybe this is excessive, but could we test all of the available protocols? I'm curious if any of the components would break.

@dsherry dsherry requested review from angela97lin and gsheni Aug 5, 2020
assert component.parameters == loaded_component.parameters
assert component.describe(return_dict=True) == loaded_component.describe(return_dict=True)
if issubclass(component_class, Estimator):
assert (component.feature_importance == loaded_component.feature_importance).all()
Copy link
Collaborator Author

@dsherry dsherry Aug 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin thanks for the suggestion. This test now runs on every component / serialization protocol

gsheni
gsheni approved these changes Aug 5, 2020
@dsherry dsherry merged commit 2abf497 into main Aug 5, 2020
2 checks passed
@dsherry dsherry deleted the ds_821_cloudpickle_protocol branch Aug 5, 2020
This was referenced Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automl save/load: add optional "protocol" argument for cloudpickle
3 participants