-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add component save/load; add protocol argument to all save/load #1023
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1023 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 181 181
Lines 9631 9690 +59
=======================================
+ Hits 9622 9681 +59
Misses 9 9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this is excessive, but could we test all of the available protocols? I'm curious if any of the components would break.
assert component.parameters == loaded_component.parameters | ||
assert component.describe(return_dict=True) == loaded_component.describe(return_dict=True) | ||
if issubclass(component_class, Estimator): | ||
assert (component.feature_importance == loaded_component.feature_importance).all() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angela97lin thanks for the suggestion. This test now runs on every component / serialization protocol
Fix #821
Here's the doc on datastream protocols supported in
pickle
.