Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests to package #1029

Merged
merged 4 commits into from Aug 6, 2020
Merged

Adding tests to package #1029

merged 4 commits into from Aug 6, 2020

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

In order to properly build a conda package, we need to include our test files in the PyPi package by adding init files to the test directories.

After this PR gets merged, I will create release 0.13.0 that pushes these changes to PyPi.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #1029 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1029   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files         181      181           
  Lines        9690     9690           
=======================================
  Hits         9681     9681           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2abf497...076f6bd. Read the comment docs.

@freddyaboulton freddyaboulton marked this pull request as ready for review August 6, 2020 16:29
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool that you figured this out! 😁 👍

Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freddyaboulton looks good to me!

One strange question for you: What happens when a dev adds a new test folder? Can we add a unit test or a CI job which checks that all the tests have been added to the evalml package? It would be fine to file this and get to it later. The risk of not doing it is that as we move forward, some tests don't get included in the package and don't run on conda deploy.

Also I checked the dataset sizes and they're super small, so no concerns about adding them to the repo.

@freddyaboulton
Copy link
Contributor Author

@dsherry That's a really good point. I'll file an issue for creating a CI job that checks that each test is added to the package.

@freddyaboulton freddyaboulton merged commit fe67192 into main Aug 6, 2020
@freddyaboulton freddyaboulton deleted the adding-tests-to-package branch August 6, 2020 16:43
This was referenced Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants