Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CircleCI tests for other versions of Python #104

Merged
merged 15 commits into from Sep 26, 2019

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Sep 25, 2019

No description provided.

@angela97lin
Copy link
Contributor Author

angela97lin commented Sep 25, 2019

Addresses #92

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #104 into master will decrease coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   93.02%   92.54%   -0.49%     
==========================================
  Files          47       47              
  Lines        1248     1248              
==========================================
- Hits         1161     1155       -6     
- Misses         87       93       +6
Impacted Files Coverage Δ
evalml/pipelines/classification/random_forest.py 79.31% <0%> (-20.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899a91...f190b44. Read the comment docs.

@angela97lin angela97lin requested a review from kmax12 Sep 25, 2019
@angela97lin
Copy link
Contributor Author

angela97lin commented Sep 25, 2019

(Unsure if ci/circleci: python-35 test will run since I removed it?)

@jeremyliweishih
Copy link
Contributor

jeremyliweishih commented Sep 25, 2019

@angela97lin
Copy link
Contributor Author

angela97lin commented Sep 25, 2019

Right, it doesn't show up / is not queued because I've removed the test in my edits, but am confused since the merge check is still expecting it to run...

@rwedge
Copy link
Contributor

rwedge commented Sep 25, 2019

The branch settings for the repo probably has that test listed as a required check

@angela97lin angela97lin requested a review from rwedge Sep 25, 2019
kmax12
kmax12 previously approved these changes Sep 25, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

Looks good to me unless @rwedge sees anything wrong

@rwedge
Copy link
Contributor

rwedge commented Sep 25, 2019

This is going to upload a codecov report for each python version which may not be necessary

@rwedge
Copy link
Contributor

rwedge commented Sep 25, 2019

If we want the unit tests running to not be dependent on the lint tests passing we could move adopt a larger workflow graph like featuretools uses

@rwedge
Copy link
Contributor

rwedge commented Sep 26, 2019

For some reason it looks like the codecov upload isn't getting executed

@angela97lin
Copy link
Contributor Author

angela97lin commented Sep 26, 2019

Hmm... just taking a guess but since require_ci_to_pass is set to true, could it be waiting on ci/circleci: python-35 to finish running before codecov will run?

@jeremyliweishih
Copy link
Contributor

jeremyliweishih commented Sep 26, 2019

maybe you can test it by setting require_ci_to_pass = false

@rwedge
Copy link
Contributor

rwedge commented Sep 26, 2019

When I look at the py37 unit test container on circle ci it doesn't appear to run the codecov step at the end

What if we add an empty line at the end of the config file

.circleci/config.yml Outdated Show resolved Hide resolved
@rwedge
Copy link
Contributor

rwedge commented Sep 26, 2019

Looks like the codecov report is being uploaded now. Maybe we should merge it in and update the required checks?

rwedge
rwedge approved these changes Sep 26, 2019
@rwedge rwedge merged commit 3b096a5 into master Sep 26, 2019
@angela97lin angela97lin deleted the python_circleci_tests branch Sep 26, 2019
@angela97lin angela97lin mentioned this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants