-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CircleCI tests for other versions of Python #104
Conversation
Addresses #92 |
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
- Coverage 93.02% 92.54% -0.49%
==========================================
Files 47 47
Lines 1248 1248
==========================================
- Hits 1161 1155 -6
- Misses 87 93 +6
Continue to review full report at Codecov.
|
(Unsure if ci/circleci: python-35 test will run since I removed it?) |
You can check here: https://circleci.com/gh/FeatureLabs/evalml/tree/python_circleci_tests |
Right, it doesn't show up / is not queued because I've removed the test in my edits, but am confused since the merge check is still expecting it to run... |
The branch settings for the repo probably has that test listed as a required check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me unless @rwedge sees anything wrong
This is going to upload a codecov report for each python version which may not be necessary |
If we want the unit tests running to not be dependent on the lint tests passing we could move adopt a larger workflow graph like featuretools uses |
For some reason it looks like the codecov upload isn't getting executed |
Hmm... just taking a guess but since require_ci_to_pass is set to true, could it be waiting on ci/circleci: python-35 to finish running before codecov will run? |
maybe you can test it by setting |
When I look at the py37 unit test container on circle ci it doesn't appear to run the codecov step at the end What if we add an empty line at the end of the config file |
Looks like the codecov report is being uploaded now. Maybe we should merge it in and update the required checks? |
No description provided.