Standardize error when calling transform/predict before fit for pipelines #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1048 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 188 191 +3
Lines 10296 10362 +66
=======================================
+ Hits 10287 10353 +66
Misses 9 9
Continue to review full report at Codecov.
|
angela97lin
requested review from
jeremyliweishih,
dsherry and
freddyaboulton
and removed request for
jeremyliweishih
jeremyliweishih
approved these changes
Aug 13, 2020
freddyaboulton
approved these changes
Aug 17, 2020
evalml/pipelines/base_meta.py
Outdated
| @wraps(method) | ||
| def _check_for_fit(self, X=None, y=None): | ||
| klass = type(self).__name__ | ||
| if not self._is_fitted and klass and self.needs_fitting: |
There was a problem hiding this comment.
Why do we need the and klass?
There was a problem hiding this comment.
Oops we don't, glad you caught this 😅
dsherry
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
@angela97lin looks good!
What do you think of this:
- Define
BaseMetainevalml/utils/base_meta.py - Define
ComponentBaseMetainevalml/pipelines/components/component_base_meta.py - Define
PipelineBaseMetainevalml/pipelines/pipeline_base_meta.py
Approved once we confirm organization.
|
@dsherry Sure, that sounds fine to me, could be useful if we use BaseMeta for anything else. I'll update this PR accordingly. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #988