Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding type check for model_type #109

Merged
merged 4 commits into from Sep 30, 2019
Merged

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Sep 27, 2019

Addresses #85 by checking model_type before processing.

@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #109 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   92.54%   92.67%   +0.12%     
==========================================
  Files          47       47              
  Lines        1248     1256       +8     
==========================================
+ Hits         1155     1164       +9     
+ Misses         93       92       -1
Impacted Files Coverage Δ
evalml/tests/automl_tests/test_autoclassifier.py 100% <100%> (ø) ⬆️
evalml/pipelines/utils.py 100% <100%> (+2.85%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 93.61% <100%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b096a5...a307cb8. Read the comment docs.

@angela97lin angela97lin requested review from kmax12 and rwedge Sep 27, 2019
evalml/pipelines/utils.py Outdated Show resolved Hide resolved
evalml/tests/automl_tests/test_autoclassifier.py Outdated Show resolved Hide resolved
rwedge
rwedge approved these changes Sep 30, 2019
Copy link
Contributor

@rwedge rwedge left a comment

Looks good!

@angela97lin angela97lin merged commit 368f88e into master Sep 30, 2019
@angela97lin angela97lin deleted the model_type_better_error branch Sep 30, 2019
@angela97lin angela97lin mentioned this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants