-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding feature_threshold replacement for show_all_features #1097
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1097 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 192 192
Lines 10719 10736 +17
=======================================
+ Hits 10710 10727 +17
Misses 9 9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bchen1116 great work!! Nice unit tests.
I have a few requests before you merge:
- I left a suggestion about renaming the parameter to
importance_threshold
- Remove unnecessary threshold values from a few of the tests, or explain why they're necessary
- Please see my comment about updating the two new unit tests you've added.
- Delete the file
evalml/tests/utils_tests/test_graph_utils.py
which was added accidentally (was recently deleted onmain
)
I left some other nit-pick comments on style and wording, but those aren't blocking merge and could be addressed in a separate PR if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Dylan covered the major points but looks good after those comments are addressed!
fix #869
Replace
show_all_features
parameter ingraph_permutation_importance()
andgraph_feature_importance()
functionsCreating parameter
feature_threshold
to replaceshow_all_features
for graphing feature importance.