Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress bar history and changes for docs #111

Merged
merged 19 commits into from Oct 11, 2019
Merged

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Oct 1, 2019

Solves #48.
Screen Shot 2019-10-11 at 10 12 29 AM

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #111 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   93.72%   93.94%   +0.21%     
==========================================
  Files          52       54       +2     
  Lines        1355     1403      +48     
==========================================
+ Hits         1270     1318      +48     
  Misses         85       85
Impacted Files Coverage Δ
evalml/demos/__init__.py 100% <100%> (ø) ⬆️
evalml/tests/model_type_tests/test_model_types.py 100% <100%> (ø)
evalml/pipelines/utils.py 100% <100%> (ø) ⬆️
evalml/models/auto_base.py 92.3% <100%> (+0.34%) ⬆️
evalml/objectives/__init__.py 100% <100%> (ø) ⬆️
evalml/pipelines/classification/__init__.py 100% <100%> (ø) ⬆️
evalml/__init__.py 100% <100%> (ø) ⬆️
evalml/model_types/utils.py 100% <100%> (ø)
evalml/model_types/__init__.py 100% <100%> (ø) ⬆️
evalml/pipelines/__init__.py 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a819b8...ff53c28. Read the comment docs.

@jeremyliweishih jeremyliweishih requested a review from angela97lin Oct 7, 2019
evalml/models/auto_base.py Outdated Show resolved Hide resolved
Copy link
Contributor

@kmax12 kmax12 left a comment

this looks good, but we should also rerun the notebooks in the docs to reflect this change

evalml/models/auto_base.py Outdated Show resolved Hide resolved
evalml/models/auto_base.py Outdated Show resolved Hide resolved
@jeremyliweishih jeremyliweishih changed the title Show progress bar history Show progress bar history and changes for docs Oct 10, 2019
kmax12
kmax12 previously approved these changes Oct 11, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

one comment, otherwise, looks good

evalml/models/auto_base.py Outdated Show resolved Hide resolved
kmax12
kmax12 approved these changes Oct 11, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

LGTM

@jeremyliweishih jeremyliweishih merged commit 1fc3d36 into master Oct 11, 2019
kmax12
kmax12 approved these changes Oct 11, 2019
@angela97lin angela97lin mentioned this pull request Oct 29, 2019
@dsherry dsherry deleted the search-progress branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants