Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API docs for add_result_callback #1113

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Update API docs for add_result_callback #1113

merged 2 commits into from
Aug 27, 2020

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Aug 27, 2020

Fix #1096

@codecov
Copy link

codecov bot commented Aug 27, 2020 •
edited
Loading

Codecov Report

Merging #1113 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1113   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         194      194           
  Lines       10957    10957           
=======================================
  Hits        10948    10948           
  Misses          9        9
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.56% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e22cc7...46ed5ed. Read the comment docs.

angela97lin
angela97lin approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for updating this! 👍

@dsherry dsherry merged commit 2691cb3 into main Aug 27, 2020
@dsherry dsherry deleted the ds_1096_fix_callback_docs branch August 27, 2020 18:47
This was referenced Sep 17, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela97lin angela97lin angela97lin approved these changes

@bchen1116 bchen1116 Awaiting requested review from bchen1116

Assignees

@dsherry dsherry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update docs for add_result_callback to say inputted pipeline is untrained, not trained
2 participants
@dsherry @angela97lin