-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address loading in pipeline that uses unloaded custom objective class code #113
Conversation
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 94.32% 94.51% +0.19%
==========================================
Files 58 58
Lines 1516 1514 -2
==========================================
+ Hits 1430 1431 +1
+ Misses 86 83 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we switch design choices here on cloudpickle vs pickle?
Yup, discussed with @kmax12 and decided that it should be reasonable for users to use a consistent version of Python and if users do run into the case where they're pickling/unpickling with different versions then we can address it then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add cloudpickle to requirements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d628f5c
Addresses #83
Decided to explicitly tell and disallow users from loading in a pipeline that requires a custom objective unless the custom objective code is available (loaded).