Address loading in pipeline that uses unloaded custom objective class code #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angela97lin
changed the title
jeremyliweishih
requested changes
Oct 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 94.32% 94.51% +0.19%
==========================================
Files 58 58
Lines 1516 1514 -2
==========================================
+ Hits 1430 1431 +1
+ Misses 86 83 -3
Continue to review full report at Codecov.
|
kmax12
suggested changes
Oct 10, 2019
rwedge
reviewed
Oct 17, 2019
|
Yup, discussed with @kmax12 and decided that it should be reasonable for users to use a consistent version of Python and if users do run into the case where they're pickling/unpickling with different versions then we can address it then. |
rwedge
reviewed
Oct 17, 2019
angela97lin
changed the title
angela97lin
changed the title
rwedge
reviewed
Oct 22, 2019
jeremyliweishih
previously approved these changes
Oct 23, 2019
angela97lin
dismissed stale reviews from kmax12, jeremyliweishih, and rwedge
via
d628f5c
jeremyliweishih
approved these changes
Oct 28, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #83
Decided to explicitly tell and disallow users from loading in a pipeline that requires a custom objective unless the custom objective code is available (loaded).