Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin scikit-optimize to version 0.7.4 #1136

merged 3 commits into from Sep 3, 2020


Copy link

@freddyaboulton freddyaboulton commented Sep 3, 2020

Pull Request Description

The latest version of scikit-optimize breaks AutoML. This PR pins the version to not exceed 0.7.4. We may upgrade the latest version when we get to #1121

I don't think performance tests are necessary for this change since we are not upgrading any dependency versions.

After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #1136 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1136     +/-   ##
  Coverage   99.91%   99.91%             
  Files         183      195     +12     
  Lines       10143    11159   +1016     
+ Hits        10134    11150   +1016     
  Misses          9        9             
Impacted Files Coverage Δ
evalml/demos/ 100.00% <ø> (ø)
..._understanding/prediction_explanations/ 100.00% <ø> (ø)
...alml/objectives/ 100.00% <ø> (ø)
evalml/pipelines/ 100.00% <ø> (ø)
evalml/pipelines/components/ 100.00% <ø> (ø)
evalml/pipelines/components/estimators/ 100.00% <ø> (ø)
evalml/ 100.00% <100.00%> (ø)
evalml/automl/ 99.56% <100.00%> (+<0.01%) ⬆️
evalml/data_checks/ 100.00% <100.00%> (ø)
evalml/demos/ 100.00% <100.00%> (ø)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 425e335...1a30842. Read the comment docs.

Copy link

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@freddyaboulton freddyaboulton merged commit 312ae65 into main Sep 3, 2020
@freddyaboulton freddyaboulton deleted the pin-scikit-optimize-version branch September 3, 2020 17:06
This was referenced Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants