Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard for python ver in dependency check action #1137

Merged
merged 2 commits into from Sep 3, 2020

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Sep 3, 2020

No description provided.

@jeremyliweishih jeremyliweishih requested review from eccabay, angela97lin, bchen1116 and freddyaboulton and removed request for eccabay Sep 3, 2020
Copy link
Contributor

@angela97lin angela97lin left a comment

:shipit:

@angela97lin
Copy link
Contributor

angela97lin commented Sep 3, 2020

@jeremyliweishih Do you think it's worth manually updating latest dependencies here? Or should we wait for bot to be back up and automate the PR?

@jeremyliweishih
Copy link
Contributor Author

jeremyliweishih commented Sep 3, 2020

@angela97lin Thats a good idea but since we know the issue is with skopt I want the bot to update it to confirm its working as intended 😄

@jeremyliweishih jeremyliweishih merged commit 425e335 into main Sep 3, 2020
@angela97lin
Copy link
Contributor

angela97lin commented Sep 3, 2020

@jeremyliweishih Gotcha, makes sense to me!

This was referenced Sep 17, 2020
@freddyaboulton freddyaboulton deleted the js_fix_action_again branch May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants