Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue where Imputer cannot fit when there is None in a categorical or boolean column #1144

Merged
merged 4 commits into from
Sep 8, 2020
Merged

Fixes issue where Imputer cannot fit when there is None in a categorical or boolean column #1144

merged 4 commits into from
Sep 8, 2020

Conversation

angela97lin
Copy link
Contributor

Closes #1075

@angela97lin angela97lin added this to the September 2020 milestone Sep 4, 2020
@angela97lin angela97lin self-assigned this Sep 4, 2020
@codecov
Copy link

codecov bot commented Sep 4, 2020 •
edited
Loading

Codecov Report

Merging #1144 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1144   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         195      195           
  Lines       11460    11489   +29     
=======================================
+ Hits        11450    11479   +29     
  Misses         10       10
Impacted Files Coverage Δ
...elines/components/transformers/imputers/imputer.py 100.00% <ø> (ø)
...components/transformers/imputers/simple_imputer.py 100.00% <100.00%> (ø)
evalml/tests/component_tests/test_imputer.py 100.00% <100.00%> (ø)
...valml/tests/component_tests/test_simple_imputer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 221bceb...7aa2ae1. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review September 4, 2020 19:59
freddyaboulton
freddyaboulton approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin Looks good to me!

evalml/tests/component_tests/test_imputer.py Show resolved Hide resolved
@angela97lin angela97lin merged commit b88c9c6 into main Sep 8, 2020
@angela97lin angela97lin deleted the 1075_none branch September 8, 2020 14:55
This was referenced Sep 17, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddyaboulton freddyaboulton freddyaboulton approved these changes

@dsherry dsherry Awaiting requested review from dsherry

@jeremyliweishih jeremyliweishih Awaiting requested review from jeremyliweishih

@bchen1116 bchen1116 Awaiting requested review from bchen1116

@eccabay eccabay Awaiting requested review from eccabay

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
September 2020
Development

Successfully merging this pull request may close these issues.

Imputer cannot fit when there is None in a categorical or boolean column
2 participants
@angela97lin @freddyaboulton