Skip to content

Conversation

@angela97lin
Copy link
Contributor

Closes #1075

@angela97lin angela97lin added this to the September 2020 milestone Sep 4, 2020
@angela97lin angela97lin self-assigned this Sep 4, 2020
@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #1144 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1144   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         195      195           
  Lines       11460    11489   +29     
=======================================
+ Hits        11450    11479   +29     
  Misses         10       10           
Impacted Files Coverage Δ
...elines/components/transformers/imputers/imputer.py 100.00% <ø> (ø)
...components/transformers/imputers/simple_imputer.py 100.00% <100.00%> (ø)
evalml/tests/component_tests/test_imputer.py 100.00% <100.00%> (ø)
...valml/tests/component_tests/test_simple_imputer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 221bceb...7aa2ae1. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review September 4, 2020 19:59
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin Looks good to me!

@angela97lin angela97lin merged commit b88c9c6 into main Sep 8, 2020
@angela97lin angela97lin deleted the 1075_none branch September 8, 2020 14:55
This was referenced Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Imputer cannot fit when there is None in a categorical or boolean column

3 participants