Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneHotEncoder Preserves Custom Index #1146

Merged
merged 3 commits into from
Sep 10, 2020

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Sep 8, 2020

Pull Request Description

Fixes #1074.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #1146 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1146   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         195      195           
  Lines       11506    11515    +9     
=======================================
+ Hits        11496    11505    +9     
  Misses         10       10           
Impacted Files Coverage Δ
...components/transformers/encoders/onehot_encoder.py 100.00% <100.00%> (ø)
...alml/tests/component_tests/test_one_hot_encoder.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03eaef6...0e413d6. Read the comment docs.

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test! LGTM 😄 🚢

@freddyaboulton freddyaboulton force-pushed the 1074-ohe-introduces-nans-custom-index branch 4 times, most recently from effc79b to d59f91d Compare September 10, 2020 16:54
@freddyaboulton freddyaboulton force-pushed the 1074-ohe-introduces-nans-custom-index branch from d59f91d to 0e413d6 Compare September 10, 2020 19:37
@freddyaboulton freddyaboulton merged commit 59f1bd3 into main Sep 10, 2020
This was referenced Sep 17, 2020
@freddyaboulton freddyaboulton deleted the 1074-ohe-introduces-nans-custom-index branch October 22, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OneHotEncoder introduces NaNs when dataframe has custom index
3 participants