-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OneHotEncoder Preserves Custom Index #1146
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1146 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 195 195
Lines 11506 11515 +9
=======================================
+ Hits 11496 11505 +9
Misses 10 10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test! LGTM 😄 🚢
effc79b
to
d59f91d
Compare
d59f91d
to
0e413d6
Compare
Pull Request Description
Fixes #1074.
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.