Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all references to 'label' to 'target' if problem type is not classification #1160

Merged
merged 22 commits into from Sep 22, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Sep 11, 2020

Closes #829 by updating API reference to use "target" instead of "label" in non-classification contexts.

I also did some general docstring cleanup (Args --> Arguments, capitalization)

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #1160 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1160   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         196      196           
  Lines       11995    11995           
=======================================
  Hits        11986    11986           
  Misses          9        9           
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.58% <ø> (ø)
evalml/automl/pipeline_search_plots.py 100.00% <ø> (ø)
evalml/data_checks/data_checks.py 100.00% <ø> (ø)
evalml/data_checks/highly_null_data_check.py 100.00% <ø> (ø)
evalml/data_checks/id_columns_data_check.py 100.00% <ø> (ø)
evalml/data_checks/invalid_targets_data_check.py 100.00% <ø> (ø)
evalml/data_checks/label_leakage_data_check.py 100.00% <ø> (ø)
evalml/data_checks/outliers_data_check.py 100.00% <ø> (ø)
evalml/demos/churn.py 100.00% <ø> (ø)
evalml/demos/fraud.py 100.00% <ø> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae5014...ded3f99. Read the comment docs.

@angela97lin angela97lin self-assigned this Sep 11, 2020
@angela97lin angela97lin added this to the September 2020 milestone Sep 11, 2020
@angela97lin angela97lin marked this pull request as ready for review Sep 11, 2020
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

@angela97lin Thanks for doing this! I left non-blocking comments. The main theme is that sometimes we say target data, target values, or true values in regression contexts. Might be nice to standardize but not blocking as it's pretty minor.

evalml/model_understanding/graphs.py Outdated Show resolved Hide resolved
evalml/model_understanding/graphs.py Outdated Show resolved Hide resolved
evalml/model_understanding/graphs.py Show resolved Hide resolved
evalml/pipelines/utils.py Outdated Show resolved Hide resolved
evalml/preprocessing/utils.py Outdated Show resolved Hide resolved
evalml/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
Copy link
Contributor

@bchen1116 bchen1116 left a comment

LGTM

Copy link
Collaborator

@dsherry dsherry left a comment

@angela97lin thank you for doing this!

evalml/model_understanding/graphs.py Outdated Show resolved Hide resolved
@angela97lin angela97lin merged commit d42fd6e into main Sep 22, 2020
@angela97lin angela97lin deleted the 829_target branch Sep 22, 2020
@angela97lin angela97lin mentioned this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components: update API doc to refer to target as "target" instead of "labels"
4 participants