-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all references to 'label' to 'target' if problem type is not classification #1160
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1160 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 196 196
Lines 11995 11995
=======================================
Hits 11986 11986
Misses 9 9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angela97lin Thanks for doing this! I left non-blocking comments. The main theme is that sometimes we say target data
, target values
, or true values
in regression contexts. Might be nice to standardize but not blocking as it's pretty minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angela97lin thank you for doing this!
Closes #829 by updating API reference to use "target" instead of "label" in non-classification contexts.
I also did some general docstring cleanup (Args --> Arguments, capitalization)