Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the threshold to the ROC curve hovertext #1161

Merged
merged 2 commits into from Sep 14, 2020

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Sep 11, 2020

Pull Request Description

Fixes #1091 by displaying the threshold corresponding to each point in the ROC curve when the user hovers over the point. Before, the hovertext only included the x, y coordinate tuple, so I also added False Positive Rate and True Positive Rate as well to make it clearer. I can revert that change though since it's not mentioned in the original issue.

What it looks like to a user

Screen Shot 2020-09-11 at 1 14 24 PM


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #1161 into main will increase coverage by 8.90%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1161      +/-   ##
==========================================
+ Coverage   91.00%   99.91%   +8.90%     
==========================================
  Files         197      197              
  Lines       11650    11653       +3     
==========================================
+ Hits        10602    11643    +1041     
+ Misses       1048       10    -1038     
Impacted Files Coverage Δ
evalml/model_understanding/graphs.py 100.00% <100.00%> (+52.76%) ⬆️
...lml/tests/model_understanding_tests/test_graphs.py 100.00% <100.00%> (+42.59%) ⬆️
evalml/tests/component_tests/test_components.py 100.00% <0.00%> (+0.38%) ⬆️
evalml/automl/automl_search.py 99.58% <0.00%> (+0.41%) ⬆️
...s/prediction_explanations_tests/test_algorithms.py 100.00% <0.00%> (+1.11%) ⬆️
evalml/tests/component_tests/test_utils.py 100.00% <0.00%> (+3.57%) ⬆️
...derstanding/prediction_explanations/_algorithms.py 97.14% <0.00%> (+4.28%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 100.00% <0.00%> (+4.86%) ⬆️
evalml/tests/utils_tests/test_dependencies.py 100.00% <0.00%> (+6.25%) ⬆️
evalml/utils/gen_utils.py 98.94% <0.00%> (+6.31%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4e98e...cf718dd. Read the comment docs.

@freddyaboulton freddyaboulton changed the title Adding the threshold to the ROC hovertext Adding the threshold to the ROC curve hovertext Sep 11, 2020
@freddyaboulton freddyaboulton marked this pull request as ready for review Sep 11, 2020
@freddyaboulton freddyaboulton force-pushed the 1091-add-threshold-to-roc-curve-graph branch from 1762769 to cf718dd Compare Sep 11, 2020
Copy link
Contributor

@angela97lin angela97lin left a comment

:shipit: 🚢

gsheni
gsheni approved these changes Sep 14, 2020
Copy link
Member

@gsheni gsheni left a comment

chart looks good!

@freddyaboulton freddyaboulton merged commit bab52e2 into main Sep 14, 2020
This was referenced Sep 17, 2020
@freddyaboulton freddyaboulton deleted the 1091-add-threshold-to-roc-curve-graph branch Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROC curve: add hover text to display thresholds for each point
3 participants