-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the threshold to the ROC curve hovertext #1161
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1161 +/- ##
==========================================
+ Coverage 91.00% 99.91% +8.90%
==========================================
Files 197 197
Lines 11650 11653 +3
==========================================
+ Hits 10602 11643 +1041
+ Misses 1048 10 -1038
Continue to review full report at Codecov.
|
…False positive rate as well.
1762769
to
cf718dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chart looks good!
Pull Request Description
Fixes #1091 by displaying the threshold corresponding to each point in the ROC curve when the user hovers over the point. Before, the hovertext only included the x, y coordinate tuple, so I also added
False Positive Rate
andTrue Positive Rate
as well to make it clearer. I can revert that change though since it's not mentioned in the original issue.What it looks like to a user
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.