-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Model Family repr #1165
Fix Model Family repr #1165
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1165 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 197 197
Lines 11653 11663 +10
=======================================
+ Hits 11643 11653 +10
Misses 10 10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One more thing to add would be a test case to ensure the output of the list of enums would not appear as [, , , ,]
. I think you can achieve this by calling repr([enums])
. Might be good to add the same for printing the list as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Jeremy's comments but otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix #1112
Fix so that the representation of model family is understandable.