Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Model Family repr #1165

Merged
merged 7 commits into from
Sep 14, 2020
Merged

Fix Model Family repr #1165

merged 7 commits into from
Sep 14, 2020

Conversation

bchen1116
Copy link
Contributor

fix #1112

Fix so that the representation of model family is understandable.

@bchen1116 bchen1116 self-assigned this Sep 14, 2020
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #1165 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1165   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         197      197           
  Lines       11653    11663   +10     
=======================================
+ Hits        11643    11653   +10     
  Misses         10       10           
Impacted Files Coverage Δ
evalml/model_family/model_family.py 100.00% <100.00%> (ø)
...alml/tests/model_family_tests/test_model_family.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca9acb...96b5742. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One more thing to add would be a test case to ensure the output of the list of enums would not appear as [, , , ,]. I think you can achieve this by calling repr([enums]). Might be good to add the same for printing the list as well.

evalml/tests/model_family_tests/test_model_family.py Outdated Show resolved Hide resolved
evalml/model_family/model_family.py Show resolved Hide resolved
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Jeremy's comments but otherwise LGTM!

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bchen1116 bchen1116 merged commit b38b51b into main Sep 14, 2020
This was referenced Sep 17, 2020
@freddyaboulton freddyaboulton deleted the bc_1112_str branch May 13, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModelFamily: pretty printing
3 participants