Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate nbsphinx dependency in dev-requirements.txt #1168

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Remove duplicate nbsphinx dependency in dev-requirements.txt #1168

merged 2 commits into from
Sep 14, 2020

Conversation

angela97lin
Copy link
Contributor

Removes duplicate nbsphinx dependency in dev-requirements.txt

@codecov
Copy link

codecov bot commented Sep 14, 2020 •
edited
Loading

Codecov Report

Merging #1168 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1168   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         197      197           
  Lines       11653    11653           
=======================================
  Hits        11643    11643           
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bab52e2...bb5784f. Read the comment docs.

@angela97lin angela97lin added this to the September 2020 milestone Sep 14, 2020
freddyaboulton
freddyaboulton approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @angela97lin !

@angela97lin angela97lin merged commit 8ca9acb into main Sep 14, 2020
@angela97lin angela97lin deleted the ange_remove_dup_dependency branch September 14, 2020 19:48
This was referenced Sep 17, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddyaboulton freddyaboulton freddyaboulton approved these changes

@gsheni gsheni Awaiting requested review from gsheni

@dsherry dsherry Awaiting requested review from dsherry

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
September 2020
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@angela97lin @freddyaboulton