Removing tqdm as a dependency #1177
Conversation
freddyaboulton
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1177 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 196 196
Lines 11700 11710 +10
=======================================
+ Hits 11691 11701 +10
Misses 9 9
Continue to review full report at Codecov.
|
freddyaboulton
requested review from
jeremyliweishih,
christopherbunn,
bchen1116 and
eccabay
| @@ -22,7 +22,7 @@ def current_dir(): | |||
|
|
|||
|
|
|||
| def test_get_core_requirements(): | |||
| assert len(get_core_requirements()) == 13 | |||
| assert len(get_core_requirements()) == 12 | |||
There was a problem hiding this comment.
@freddyaboulton why is this change needed?
There was a problem hiding this comment.
I think it's because I removed tqdm from the core-depencies.txt. Circle-ci failed without the change but let me know if I'm misunderstanding!
There was a problem hiding this comment.
Oh... sorry, I forgot this is a list of the number of lines in the core requirements, not the list of the number of components we define 🤦 proceed!
| return tqdm.std.tqdm.format_interval(time.time() - start_time) | ||
|
|
||
| time_diff = time.time() - start_time | ||
| # Source: tqdm.std.tqdm.format_interval |
freddyaboulton
requested review from
dsherry and
angela97lin
and removed request for
christopherbunn,
jeremyliweishih,
bchen1116 and
eccabay
freddyaboulton
force-pushed
the
remove-tqdm-dependency
branch
from
7043582
to
551e9dc
Compare
Pull Request Description
Fixes #1175 .
Logging output stays the same
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.