Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing tqdm as a dependency #1177

Merged
merged 6 commits into from Sep 16, 2020
Merged

Removing tqdm as a dependency #1177

merged 6 commits into from Sep 16, 2020

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Sep 15, 2020

Pull Request Description

Fixes #1175 .

Logging output stays the same

image


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@freddyaboulton freddyaboulton changed the title Removing tqdm as a requirement. Removing tqdm as a dependency Sep 15, 2020
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #1177 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1177   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         196      196           
  Lines       11700    11710   +10     
=======================================
+ Hits        11691    11701   +10     
  Misses          9        9           
Impacted Files Coverage Δ
evalml/tests/utils_tests/test_cli_utils.py 100.00% <100.00%> (ø)
evalml/tests/utils_tests/test_logger.py 100.00% <100.00%> (ø)
evalml/utils/logger.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35aae78...551e9dc. Read the comment docs.

@@ -22,7 +22,7 @@ def current_dir():


def test_get_core_requirements():
assert len(get_core_requirements()) == 13
assert len(get_core_requirements()) == 12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freddyaboulton why is this change needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because I removed tqdm from the core-depencies.txt. Circle-ci failed without the change but let me know if I'm misunderstanding!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... sorry, I forgot this is a list of the number of lines in the core requirements, not the list of the number of components we define 🤦 proceed!

Copy link
Collaborator

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just left one question on a test change.

return tqdm.std.tqdm.format_interval(time.time() - start_time)

time_diff = time.time() - start_time
# Source: tqdm.std.tqdm.format_interval
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! Glad we're moving away from tqdm given that it's given us some trouble in the past 😅

@freddyaboulton freddyaboulton merged commit fd65f56 into main Sep 16, 2020
This was referenced Sep 17, 2020
@freddyaboulton freddyaboulton deleted the remove-tqdm-dependency branch October 22, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove tqdm dependency
3 participants