Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding lightgbm to latest_dependency_versions.txt. #1185

Merged
merged 7 commits into from Sep 17, 2020

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Sep 16, 2020

Pull Request Description

Adds lightgbm==3.0.0 to the latest_dependency_versions.txt


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #1185 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1185   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         196      196           
  Lines       11780    11780           
=======================================
  Hits        11771    11771           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d1303c...3a1d3ff. Read the comment docs.

@freddyaboulton freddyaboulton self-assigned this Sep 16, 2020
@freddyaboulton freddyaboulton force-pushed the add-lightgbm-to-latest_dependency_versions.txt branch from da2721e to dfb0709 Compare Sep 16, 2020
@freddyaboulton
Copy link
Contributor Author

freddyaboulton commented Sep 16, 2020

@jeremyliweishih says that check_dependencies_updated_linux may be broken when you manually update the file. This is what circle-ci is returning (link)

image

I think this is good to merge with a failing check_dependencies_updated_linux job. FYI @dsherry

@freddyaboulton freddyaboulton marked this pull request as ready for review Sep 16, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

Thank you!

The fact that we missed this has me wondering if there's a better pattern we should follow. Any ideas?

@dsherry
Copy link
Collaborator

dsherry commented Sep 16, 2020

@freddyaboulton I see this in the diff in the failing deps updated job: "\ No newline at end of file" so I think you gotta add a newline to the end of the latest deps txt file

@freddyaboulton
Copy link
Contributor Author

freddyaboulton commented Sep 16, 2020

@dsherry It is still failing with the new line

@dsherry
Copy link
Collaborator

dsherry commented Sep 16, 2020

@freddyaboulton see here: you need to move the lightgbm line up so the diff will pass! I forgot that order matters here, lol

@freddyaboulton freddyaboulton force-pushed the add-lightgbm-to-latest_dependency_versions.txt branch from eccc66a to 99e321e Compare Sep 17, 2020
@freddyaboulton freddyaboulton merged commit 7df065e into main Sep 17, 2020
@freddyaboulton freddyaboulton deleted the add-lightgbm-to-latest_dependency_versions.txt branch Sep 17, 2020
This was referenced Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants