-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding lightgbm to latest_dependency_versions.txt. #1185
Adding lightgbm to latest_dependency_versions.txt. #1185
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1185 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 196 196
Lines 11780 11780
=======================================
Hits 11771 11771
Misses 9 9 Continue to review full report at Codecov.
|
da2721e
to
dfb0709
Compare
@jeremyliweishih says that I think this is good to merge with a failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The fact that we missed this has me wondering if there's a better pattern we should follow. Any ideas?
@freddyaboulton I see this in the diff in the failing deps updated job: "\ No newline at end of file" so I think you gotta add a newline to the end of the latest deps txt file |
@freddyaboulton see here: you need to move the |
eccc66a
to
99e321e
Compare
Pull Request Description
Adds
lightgbm==3.0.0
to thelatest_dependency_versions.txt
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.