Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving logging into its own util module #119

Merged
merged 2 commits into from Oct 10, 2019
Merged

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Oct 9, 2019

Fixes #117

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #119 into master will increase coverage by 0.03%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   93.45%   93.49%   +0.03%     
==========================================
  Files          50       52       +2     
  Lines        1299     1306       +7     
==========================================
+ Hits         1214     1221       +7     
  Misses         85       85
Impacted Files Coverage Δ
evalml/model_types/__init__.py 100% <ø> (ø) ⬆️
evalml/utils/__init__.py 100% <100%> (ø)
evalml/__init__.py 100% <100%> (ø) ⬆️
evalml/models/auto_base.py 91.35% <82.6%> (-0.15%) ⬇️
evalml/utils/logging_utils.py 95% <95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f82885...9d2303b. Read the comment docs.

@angela97lin angela97lin requested a review from kmax12 Oct 10, 2019
kmax12
kmax12 approved these changes Oct 10, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

LGTM

@jeremyliweishih jeremyliweishih merged commit c671859 into master Oct 10, 2019
@angela97lin angela97lin deleted the util_logging branch Oct 10, 2019
@angela97lin angela97lin mentioned this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move logging out of AutoBase (into utils)
3 participants