-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Class Imbalance data check to api docs #1190
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1190 +/- ##
==========================================
+ Coverage 99.74% 99.92% +0.18%
==========================================
Files 196 196
Lines 11977 11978 +1
==========================================
+ Hits 11946 11969 +23
+ Misses 31 9 -22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: you can view here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but @bchen1116 can I make the suggestion that you update the docstring of the ClassImbalanceDataCheck to not start with "Classification problem," as to better match the other data checks?
@bchen1116 looks good! Please use a slightly more descriptive PR title, like "Add class imbalance data check to API ref". It makes it easier to understand what's in the PR quickly, and to search through old PRs / the logs. |
Add class Imbalance Data check to the api documentation