Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer Problem type #1194

Merged
merged 29 commits into from Sep 28, 2020
Merged

Infer Problem type #1194

merged 29 commits into from Sep 28, 2020

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Sep 17, 2020

fix #826

Create a method to infer problem type given the target data. Design doc for this is here

Updated api docs here

@bchen1116 bchen1116 self-assigned this Sep 17, 2020
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #1194 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1194   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         196      196           
  Lines       12121    12193   +72     
=======================================
+ Hits        12112    12184   +72     
  Misses          9        9           
Impacted Files Coverage Δ
evalml/utils/gen_utils.py 99.02% <ø> (ø)
evalml/problem_types/__init__.py 100.00% <100.00%> (ø)
evalml/problem_types/utils.py 100.00% <100.00%> (ø)
...lml/tests/problem_type_tests/test_problem_types.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f4bb3...b9ad9b5. Read the comment docs.

@bchen1116 bchen1116 marked this pull request as ready for review Sep 22, 2020
angela97lin
angela97lin previously requested changes Sep 24, 2020
Copy link
Contributor

@angela97lin angela97lin left a comment

Looking good, made some suggestions on returning ProblemTypes enum instead.

Also, we should revert the line break deletions, as they're updating the docs and making things look funky.

evalml/utils/gen_utils.py Outdated Show resolved Hide resolved
evalml/utils/gen_utils.py Outdated Show resolved Hide resolved
evalml/problem_types/utils.py Show resolved Hide resolved
evalml/problem_types/utils.py Outdated Show resolved Hide resolved
evalml/tests/problem_type_tests/test_problem_types.py Outdated Show resolved Hide resolved
evalml/problem_types/utils.py Outdated Show resolved Hide resolved
evalml/tests/problem_type_tests/test_problem_types.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dsherry dsherry left a comment

@bchen1116 looks good!

Could you add something about this to the user guide? We should show it off because its cool :) I suggest right before this paragraph in the AutoML guide.

Other than that, looks great! I left a few comments. @angela97lin beat me to it on most of them 😂 Your unit tests are great.

evalml/problem_types/utils.py Outdated Show resolved Hide resolved
evalml/problem_types/utils.py Outdated Show resolved Hide resolved
evalml/tests/problem_type_tests/test_problem_types.py Outdated Show resolved Hide resolved
evalml/utils/gen_utils.py Outdated Show resolved Hide resolved
@bchen1116 bchen1116 requested a review from angela97lin Sep 25, 2020
@bchen1116
Copy link
Contributor Author

bchen1116 commented Sep 25, 2020

Docs here

@bchen1116 bchen1116 requested a review from dsherry Sep 25, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

👍 🚀

docs/source/user_guide/automl.ipynb Outdated Show resolved Hide resolved
evalml/problem_types/utils.py Outdated Show resolved Hide resolved
@bchen1116 bchen1116 dismissed angela97lin’s stale review Sep 28, 2020

Issues addressed!

Copy link
Contributor

@angela97lin angela97lin left a comment

LGTM! :shipit:

@bchen1116 bchen1116 merged commit 7d2f3ce into main Sep 28, 2020
@angela97lin angela97lin mentioned this pull request Sep 29, 2020
@freddyaboulton freddyaboulton deleted the bc_826_targets branch May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automl: infer problem type from target data
3 participants