-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer Problem type #1194
Infer Problem type #1194
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1194 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 196 196
Lines 12121 12193 +72
=======================================
+ Hits 12112 12184 +72
Misses 9 9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, made some suggestions on returning ProblemTypes
enum instead.
Also, we should revert the line break deletions, as they're updating the docs and making things look funky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bchen1116 looks good!
Could you add something about this to the user guide? We should show it off because its cool :) I suggest right before this paragraph in the AutoML guide.
Other than that, looks great! I left a few comments. @angela97lin beat me to it on most of them 😂 Your unit tests are great.
Docs here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
fix #826
Create a method to infer problem type given the target data. Design doc for this is here
Updated api docs here