Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub URL from FeatureLabs to Alteryx #1207

Merged
merged 3 commits into from Sep 21, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Sep 21, 2020

Now that we've moved the repo to the "alteryx" org, we need to update our docs, github actions etc. to correspond.

@dsherry dsherry marked this pull request as ready for review Sep 21, 2020
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Thanks @dsherry !

release.md Outdated
* The [ReadtheDocs build](https://readthedocs.com/projects/feature-labs-inc-evalml/builds/) for "latest" is marked as passed. To avoid mysterious errors, best practice is to empty your browser cache when reading new versions of the docs!
* The [public documentation for the "latest" branch](https://evalml.featurelabs.com/en/latest/) looks correct, and the [release notes](https://evalml.featurelabs.com/en/latest/release_notes.html) includes the last change which was made on main.
* The [performance tests](https://github.com/FeatureLabs/evalml_looking_glass) have passed on latest main, and the team has reviewed the results.
* The [performance tests](https://github.com/alteryx/evalml_looking_glass) have passed on latest main, and the team has reviewed the results.
Copy link
Contributor

@freddyaboulton freddyaboulton Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think looking glass has been moved?

Copy link
Collaborator Author

@dsherry dsherry Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops yeah thanks will fix

@@ -46,4 +46,4 @@ installdeps-dev:
.PHONY: dependenciesfile
dependenciesfile:
$(eval allow_list='pandas|numpy|scikit|xgboost|catboost|cloudpickle|distributed|pyzmq|lightgbm')
pip freeze | grep -v "FeatureLabs/evalml.git" | grep -E $(allow_list) > $(DEPENDENCY_FILE_PATH)
pip freeze | grep -v "evalml.git" | grep -E $(allow_list) > $(DEPENDENCY_FILE_PATH)
Copy link
Contributor

@angela97lin angela97lin Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we need alteryx/evalml.git instead? :o

Copy link
Collaborator Author

@dsherry dsherry Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try it out! It has to do with how the local install shows up in pip freeze

Copy link
Collaborator Author

@dsherry dsherry Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter what the org is, just need to grep for the evalml git repo

Copy link
Contributor

@angela97lin angela97lin left a comment

LGTM! Just had one question I was curious about.

@dsherry dsherry merged commit 826b35b into main Sep 21, 2020
@dsherry
Copy link
Collaborator Author

dsherry commented Sep 21, 2020

Codecov is still broken!

@angela97lin angela97lin mentioned this pull request Sep 29, 2020
@freddyaboulton freddyaboulton deleted the ds_fix_release_notes_updated_check branch May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants