Simplify Problem Type Enum names for both BINARY and MULTICLASS #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchen1116
requested review from
freddyaboulton,
dsherry,
angela97lin and
jeremyliweishih
and removed request for
freddyaboulton and
dsherry
added 2 commits
September 21, 2020 15:48
bchen1116
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1208 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 196 196
Lines 11995 11999 +4
=======================================
+ Hits 11986 11990 +4
Misses 9 9
Continue to review full report at Codecov.
|
freddyaboulton
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
@bchen1116 This looks good to me! I think we should use all lowercase in the string representation of the problem types.
dsherry
reviewed
Sep 23, 2020
There was a problem hiding this comment.
@bchen1116 I didn't review this in time to approve, but this output looks great! 😁
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1197
Make Enum value and string name value of ProblemTypes (Binary and Multiclass) more similar to each other.