Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Problem Type Enum names for both BINARY and MULTICLASS #1208

Merged
merged 10 commits into from Sep 22, 2020

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Sep 21, 2020

Fix #1197

Make Enum value and string name value of ProblemTypes (Binary and Multiclass) more similar to each other.

@bchen1116 bchen1116 self-assigned this Sep 21, 2020
@bchen1116 bchen1116 requested review from freddyaboulton, dsherry, angela97lin and jeremyliweishih and removed request for freddyaboulton and dsherry Sep 21, 2020
bchen1116 added 2 commits Sep 21, 2020
@bchen1116 bchen1116 changed the title Fix Problem Type Enum names for both BINARY and MULTICLASS Simplify Problem Type Enum names for both BINARY and MULTICLASS Sep 21, 2020
@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #1208 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1208   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         196      196           
  Lines       11995    11999    +4     
=======================================
+ Hits        11986    11990    +4     
  Misses          9        9           
Impacted Files Coverage Δ
evalml/problem_types/problem_types.py 100.00% <100.00%> (ø)
evalml/tests/automl_tests/test_automl.py 100.00% <100.00%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 100.00% <100.00%> (ø)
...lml/tests/problem_type_tests/test_problem_types.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93cd5e6...dbe0ac7. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

@bchen1116 This looks good to me! I think we should use all lowercase in the string representation of the problem types.

evalml/problem_types/problem_types.py Outdated Show resolved Hide resolved
@bchen1116 bchen1116 merged commit cc53514 into main Sep 22, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

@bchen1116 I didn't review this in time to approve, but this output looks great! 😁

@angela97lin angela97lin mentioned this pull request Sep 29, 2020
@freddyaboulton freddyaboulton deleted the bc_1197_problem_type branch May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify problem_type
3 participants