This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quick comment. if we drop columns on training data, we need to drop the same columns on the test data even if they aren't highly null. would it be better to create this a component in the pipeline with fit/predict?
Hmmm, since the columns are dropped before it is passed to _do_iteration(...) where the split into training and testing data happens, we don't have to manually drop the columns in the test data too? Still, do you think it'd make more sense with the restructuring of pipelines?
and actually, as I think about it, we don't want to drop columns based on the test data. that would be creating label leakage. we should only drop columns based on what is in the training data split e.g "learn" what columns to drop on the train data, but reuse that learned selection on test data and future usage.
Ah, I think I see what you mean. In that case, should I connect (rebase) this with the pipeline components PR we’re working on for pipeline_v2 to create an actual Component and then merge it when we merge in the new pipeline code?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.