Add validation_score as 1st CV fold score into rankings #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyliweishih
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1221 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 200 200
Lines 12365 12369 +4
=======================================
+ Hits 12356 12360 +4
Misses 9 9
Continue to review full report at Codecov.
|
jeremyliweishih
requested review from
freddyaboulton,
angela97lin,
dsherry,
bchen1116,
christopherbunn and
eccabay
and removed request for
freddyaboulton and
angela97lin
|
If we're using the first CV fold score as the validation score, shouldn't the |
freddyaboulton
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
@jeremyliweishih Looks good to me! Are you planning on updating the docs/user guide? Might be worth explaining the difference between score and validation_score ?
|
@freddyaboulton good idea, i'll take a look. |
dsherry
approved these changes
Sep 29, 2020
| @@ -697,7 +697,8 @@ def _add_result(self, trained_pipeline, parameters, training_time, cv_data, cv_s | |||
| "high_variance_cv": high_variance_cv, | |||
| "training_time": training_time, | |||
| "cv_data": cv_data, | |||
| "percent_better_than_baseline": percent_better | |||
| "percent_better_than_baseline": percent_better, | |||
| "validation_score": cv_scores[0] | |||
There was a problem hiding this comment.
Awesome, I didn't realize how simple this code change would be! 👍
docs/source/user_guide/automl.ipynb
Outdated
| @@ -236,7 +236,7 @@ | |||
| "name": "python", | |||
| "nbconvert_exporter": "python", | |||
| "pygments_lexer": "ipython3", | |||
| "version": "3.8.2" | |||
| "version": "3.7.4" | |||
| @@ -134,7 +134,7 @@ | |||
| "metadata": {}, | |||
| "source": [ | |||
| "## View Rankings\n", | |||
| "A summary of all the pipelines built can be returned as a pandas DataFrame which is sorted by score." | |||
| "A summary of all the pipelines built can be returned as a pandas DataFrame which is sorted by score. The score column contains the average score across all cross-validation folds while the validation_score column is computed from the first cross-validation fold." | |||
| @@ -75,14 +75,15 @@ def test_search_results(X_y_regression, X_y_binary, X_y_multi, automl_type): | |||
| for score in all_objective_scores.values(): | |||
| assert score is not None | |||
| assert automl.get_pipeline(pipeline_id).parameters == results['parameters'] | |||
| assert results['validation_score'] == pd.Series([fold['score'] for fold in results['cv_data']])[0] | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1115.